-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Upgrade to Next.js 15 #762
Conversation
"@types/react": "npm:[email protected]", | ||
"@types/react-dom": "npm:[email protected]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from their codemod
"react": "19.0.0-rc-69d4b800-20241021", | ||
"react-dom": "19.0.0-rc-69d4b800-20241021", | ||
"react-error-boundary": "^4.0.13", | ||
"react-is": "^18.3.1", | ||
"react-is": "19.0.0-rc-69d4b800-20241021", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from their codemod
docs/shiki.config.ts
Outdated
export const shikiTheme = { | ||
light: 'github-light-default', | ||
dark: 'material-theme-ocean', | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next.js was complaining about exporting a config
from the project root, seems like this used to be some pattern that is now deprecated
For context, this file will go completely when I'm done with code blocks updates
Netlify deploy preview |
I have a feeling that making the regression tests pass will require upgrading React in all our packages, including |
@michaldudak upgraded to React 19 everywhere and the regression tests now pass
Edit: never mind, it passes after the rebase
|
We can disable the static route indicator (https://nextjs.org/docs/app/api-reference/next-config-js/devIndicators#appisrstatus-static-indicator). All our routes are prerendered at build time, so it doesn't add any value. |
I configured the CI to also run tests against React 18, as 19 won't be widely adopted yet |
@michaldudak nice, updated. Good to merge? |
FYI, ESM support in next.config.ts is coming: vercel/next.js#68365 |
Upgrade to Next.js 15,
mainly for the TypeScript config.Since we are going to use built-in @next/mdx features that are configured through the Next.js config, we need this in order to use rehype/remark plugins written in TypeScript.Edit: forget this,
next.config.ts
module resolution is CJS only, and all rehype/remark ecosystem is ESMI also briefly tried enabling Turbopack, but it doesn't work with the current demos which rely on Webpack to dynamically load the components. I'll migrate to Turbopack when we don't do the dynamic Webpack import anywhere.